-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improper emoji rendering with v5.1.0 #2865
Comments
Additional note: It works well with v5.0.5, so this got introduced with v5.1.0. |
@calculuschild Looks like this might have been broken by #2841 |
Are emojis considered punctuation or ? |
I don't think these emoji are in |
@calculuschild I've been trying to get this to work with |
We can revert if needed, but it fixed several other cases too so we would lose those fixes.
What I meant by this is are emojis meant to be treated as punctuation according to the Commonmark spec? |
I don't think so |
Marked version: v5.1.0
Describe the bug
Emoji rendering fails if located at the beginning or the end of a bold text.
I don't know if this is specific to the bold markup or if the issue happens with other markup.
To Reproduce
Steps to reproduce the behavior:
Here's a markdown text to reproduce the issue:
The text above on Markded Demo and on CommonMark Demo
Screenshot of the rendering on Marked Demo:
Expected behavior
A clear and concise description of what you expected to happen.
What is rendered on CommonMark Demo:
The text was updated successfully, but these errors were encountered: