Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix quadratic execution in em mask #2818

Merged
merged 2 commits into from May 26, 2023
Merged

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented May 25, 2023

Marked version: v5.0.2

Description

Fix quadratic execution in em mask regexp

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

vercel bot commented May 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marked-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2023 0:23am

@joshbruce
Copy link
Member

Nice!

Copy link
Contributor

@calculuschild calculuschild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow how did you notice this?

@joshbruce
Copy link
Member

@calculuschild: This was one of the first things I learned about when joining Marked on its adventure. Sometimes folks discover vulnerabilities, let the maintainers know, then the maintainers fix the issue.

This is how we met @davisjam in fact. (Mainly because I didn't handle it well - see comment history from a few years ago...I learned a lot about OSS in a very short time.)

In this case someone from Snyk sent notification in accordance with the security notice: https://github.com/markedjs/marked/blob/master/SECURITY.md

@UziTech being the awesome human he is, responded in a timely fashion with proposed solution. Snyk offered feedback to improve. And here we are. Hope that helps (and is an accurate representation).

@UziTech UziTech merged commit a37fe8e into markedjs:master May 26, 2023
11 checks passed
github-actions bot pushed a commit that referenced this pull request May 26, 2023
## [5.0.3](v5.0.2...v5.0.3) (2023-05-26)

### Bug Fixes

* fix quadratic execution in em mask ([#2818](#2818)) ([a37fe8e](a37fe8e))
@UziTech UziTech deleted the fix-em branch August 26, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants