improve: error messages for import *, multiple definition #3937
+180
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide more helpful error messages for import star and multiple definition errors, explaining the reasoning behind these errors. Also change error description text to be muted instead of red, matching the explainer text, to decrease user stress. Headlines (which describe the exception type) are still red and bold.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
for more information, see https://pre-commit.ci
mscolnick
previously approved these changes
Feb 28, 2025
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.11.12-dev1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide more helpful error messages for import star and multiple definition errors, explaining the reasoning behind these errors.
This PR also changes error description text to be muted instead of red, matching the accordion text, based on feedback that too much red can be stressful. Headlines (which describe the exception type) are still red and bold.