improve: SQL examples #2527
Merged
improve: SQL examples #2527
+983
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mscolnick
reviewed
Oct 8, 2024
|
|
||
|
|
||
| @app.cell | ||
| def __(db, duckdb_table, mo, test_table): |
There was a problem hiding this comment.
unrelated, but this import duckdb_table seems incorrect.
There was a problem hiding this comment.
yea weird that it's a def and a ref ...
There was a problem hiding this comment.
The Python code has logic for not registering something as a ref if it's a def, SQL could be missing that
mscolnick
reviewed
Oct 8, 2024
| @app.cell(hide_code=True) | ||
| def __(): | ||
| import marimo as mo | ||
| import pandas as pd |
There was a problem hiding this comment.
super nit; but i feel like we should use polars (instead of pandas) when possible
There was a problem hiding this comment.
yea i agree in general but i'd like to host these on WASM too
There was a problem hiding this comment.
oh yes good call - we did discuss that
mscolnick
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a collection of bite-sized examples showing how to use SQL: