Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the appender to use a dedicated vector-type #193

Merged
merged 6 commits into from Apr 5, 2024

Conversation

taniabogatsch
Copy link
Contributor

This PR moves all previous colInfo functions from the appender.go file into a dedicated vector.go file. Operating directly on these vectors makes the code more concise and will allow me to add future capabilities neatly. Currently planned are the following improvements to the Appender.

  • implicit type casting (e.g., after unmarshalling a JSON file)
    • add a function func (vec *vector) prepareRow(value driver.Value, tryCast bool) error improving type checks and adding implicit casting capabilities.
  • better nil/NULL handling (e.g., see discussion here: Initialise column types during appender creation #171)

@marcboeker marcboeker merged commit c6c54b9 into marcboeker:main Apr 5, 2024
4 checks passed
@taniabogatsch taniabogatsch deleted the refactor-appender branch May 6, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants