Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first follow-up PR to #187.
It focuses on unifying the error handling in the
Appender
. Additionally, errors in theAppender
no longer kill the application (panic
) and have a unified format.I'm happy that even with the introduction of new tests, this PR decreases the overall code size of the
Appender
and its tests. 馃槃 Sorry for the big PR - I've tried to keep the complexity low. Many changes are repetitive (using new functions) and structural.Other changes
connector -> c
,appender -> a
,appender *C.duckdb_appender -> duckdbAppender C.duckdb_appender
).C.duckdb_appender_destroy(&duckdbAppender)
when the appender's column type initialization fails to avoid leaks.appender_test.go
by introducing a new function:cleanupAppender
.appender_test.go
toerrors_test.go
.