Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix removing locks in recursive mode #251

Merged
merged 6 commits into from
Mar 24, 2022
Merged

Fix removing locks in recursive mode #251

merged 6 commits into from
Mar 24, 2022
+10 −7

Conversation

johaven
Copy link
Contributor

@johaven johaven commented Mar 17, 2022

Surely an oversight, in the recursive mode the child locks must be deleted. The "recursive" parameter must therefore be taken into account in the get_url_lock_list function

mar10
mar10 requested changes Mar 18, 2022
View reviewed changes
Copy link
Owner

@mar10 mar10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a line in the chagelog as well.

Thanks for contributing!

@johaven
Copy link
Contributor Author

johaven commented Mar 22, 2022 •
edited
Loading

I think it's good :)

@johaven johaven closed this Mar 22, 2022
@johaven johaven reopened this Mar 22, 2022
mar10
mar10 reviewed Mar 23, 2022
View reviewed changes
@mar10 mar10 merged commit 45cd5a2 into mar10:master Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mar10 mar10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johaven @mar10