-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add raster-dem encoding parameters to RasterDEMSourceSpecification #337
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #337 +/- ##
==========================================
+ Coverage 77.82% 77.99% +0.17%
==========================================
Files 100 101 +1
Lines 4108 4140 +32
Branches 1176 1183 +7
==========================================
+ Hits 3197 3229 +32
Misses 911 911
☔ View full report in Codecov by Sentry. |
I'm not sure the word mix is the right word here. |
Do we want to add specific valuations (and tests) for when setting the new value with mapbox ro terrain encoding? Are there any other tests that needs to be added? |
Changed them to
Added an error raised when "custom" encoding is set and you the style also sets any of the encoding parameters |
I've added a few nit picks, looks good otherwise! THANKS! |
How did you decided that it should be |
Updated, thanks for reviewing!
This was not clear to me. I did look at how the other properties of sources were called and everything, except |
Can you check that the coverage for the newly added file is 100%? |
I removed what you pointed out in your last comment and checked that the coverage didn't go down with the added file. I think this should be ready to go now? How does the process follow? Should we wait until a new package version is published to get it working on the maplibre-gl-js side? |
Yes, after meeting this there's a need to crave a release and then use it in gl js. |
Following #326 this PR adds
redMix
,blueMix
,greenMix
andbaseMix
parameters toRasterDEMSourceSpecification
See this PR on the maplibre-gl-js repo for the other part of the implementation
Launch Checklist
CHANGELOG.md
under the## main
section.