Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argument of type ShadowRoot | null is not assignable to parameter of type Element | undefined . #2089

Closed
lolmaus opened this issue Jan 13, 2024 · 0 comments
Closed

Argument of type ShadowRoot | null is not assignable to parameter of type Element | undefined . #2089

lolmaus opened this issue Jan 13, 2024 · 0 comments
Assignees
@lolmaus
Labels
beginner-friendly bug

Comments

@lolmaus
Copy link
Collaborator

lolmaus commented Jan 13, 2024

qunit-dom does work correctly with ShadowRoot, but its types do not allow for that.

Reproduction: https://github.com/lifeart/glimmer-next/blob/fa5b80ac09fe52c5b6660946cc44fa103aaba627/src/tests/integration/shadowroot-test.gts#L17C1-L18

CC @lifeart
@lolmaus lolmaus self-assigned this Jan 13, 2024
lolmaus added a commit that referenced this issue Jan 13, 2024
@lolmaus
Support ShadowRoot, add tests for rootElement, fixes #2089
3d19579
lolmaus added a commit that referenced this issue Jan 13, 2024
@lolmaus
Support ShadowRoot, add tests for rootElement, fixes #2089
b6617f4
@lolmaus lolmaus mentioned this issue Jan 13, 2024
Merged
lolmaus added a commit that referenced this issue Jan 13, 2024
@lolmaus
Support ShadowRoot, add tests for rootElement, fixes #2089
1f54ac6
BobrImperator added a commit that referenced this issue Apr 9, 2024
@BobrImperator
Merge pull request #2090 from mainmatter/root-element-shadow-dom
b755beb 
Support ShadowRoot, add tests for rootElement, fixes #2089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lolmaus lolmaus

Labels
beginner-friendly bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lolmaus