Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.2.4 has issues with make.exe path on Windows #225

Closed
ls5302 opened this issue Aug 2, 2023 · 2 comments
Closed

Release 1.2.4 has issues with make.exe path on Windows #225

ls5302 opened this issue Aug 2, 2023 · 2 comments

Comments

@ls5302
Copy link

ls5302 commented Aug 2, 2023

Building eventmachine 1.2.7 (with SSL) on a Windows 10 machine using Ruby 3.1.2 and rake-compiler v1.2.4 produces:

Command failed with status (127): [C:msys32userbin/make.exe install sitearchdir...]

Tasks: TOP => compile => compile:i386-mingw32 => compiler:rubyeventmachine:i386-mingw32 => copy:rubyeventmachine:i386-mingw32:3.1.2

Using rake-compiler v1.2.3 works with no problems.

Looks like some backslashes have disappeared.

Probably the change in extensiontask.rb around line 168.

Shellwords,shellsplit('c:\foo\bar\make.exe') => c:foobarmake.exe
Shellwords,shellsplit('c:/foo/bar/make.exe') => c:/foo/bar/make.exe

Using set MAKE=c:/msys32/usr/bin/make.exe appears to be a possible workaround as we use forward slashes.

@ls5302 ls5302 changed the title Release 1.2.4 has issue with path to on Windows Release 1.2.4 has issues with make.exe path on Windows Aug 2, 2023
flavorjones added a commit to flavorjones/rake-compiler that referenced this issue Aug 2, 2023
@kou kou closed this as completed in 6af09fd Aug 2, 2023
@kou
Copy link
Member

kou commented Aug 2, 2023

Could you try 1.2.5?

@ls5302
Copy link
Author

ls5302 commented Aug 3, 2023

All good in 1.2.5 - thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants