Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rake-compiler/rake-compiler
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.9.8
Choose a base ref
...
head repository: rake-compiler/rake-compiler
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.9.9
Choose a head ref
  • 4 commits
  • 4 files changed
  • 3 contributors

Commits on Apr 29, 2016

  1. Bump version

    kou committed Apr 29, 2016
    Copy the full SHA
    6c3d4af View commit details

Commits on May 9, 2016

  1. Accept symbol name in extension task

    Takashi Kokubun committed May 9, 2016

    Verified

    This commit was signed with the committer’s verified signature.
    caendesilva Caen De Silva
    Copy the full SHA
    af7dee6 View commit details

Commits on May 10, 2016

  1. Merge pull request #134 from k0kubun/accept-symbol-name

    Accept symbol name in extension task
    
    Patch by Takashi Kokubun. Thanks!!!
    kou committed May 10, 2016

    Verified

    This commit was signed with the committer’s verified signature.
    caendesilva Caen De Silva
    Copy the full SHA
    5692a49 View commit details
  2. Add 0.9.9 entry

    kou committed May 10, 2016

    Verified

    This commit was signed with the committer’s verified signature.
    caendesilva Caen De Silva
    Copy the full SHA
    1e2e229 View commit details
Showing with 13 additions and 1 deletion.
  1. +6 −0 History.txt
  2. +1 −0 lib/rake/baseextensiontask.rb
  3. +5 −0 spec/lib/rake/extensiontask_spec.rb
  4. +1 −1 tasks/gem.rake
6 changes: 6 additions & 0 deletions History.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
=== 0.9.9 / 2016-05-10

* Bugfixes:
* Support Symbol as extension name again.
#134 [Patch by Takashi Kokubun]

=== 0.9.8 / 2016-04-29

* Enhancements:
1 change: 1 addition & 0 deletions lib/rake/baseextensiontask.rb
Original file line number Diff line number Diff line change
@@ -46,6 +46,7 @@ def init(name = nil, gem_spec = nil)

def define
fail "Extension name must be provided." if @name.nil?
@name = @name.to_s

define_compile_tasks
end
5 changes: 5 additions & 0 deletions spec/lib/rake/extensiontask_spec.rb
Original file line number Diff line number Diff line change
@@ -17,6 +17,11 @@
ext.name.should == 'extension_one'
end

it 'should allow symbol as extension name assignation' do
ext = Rake::ExtensionTask.new(:extension_one)
ext.name.should == 'extension_one'
end

it 'should allow string as extension name using block assignation' do
ext = Rake::ExtensionTask.new do |ext|
ext.name = 'extension_two'
2 changes: 1 addition & 1 deletion tasks/gem.rake
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ require 'rubygems/package_task'
GEM_SPEC = Gem::Specification.new do |s|
# basic information
s.name = "rake-compiler"
s.version = "0.9.8"
s.version = "0.9.9"
s.platform = Gem::Platform::RUBY

# description and details