Fix in-place modification when autotuning triton Lion update #36
+3
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the autotuning modifies the parameters in place and so produces incorrect results.
You can verify this via
Running this script gives different results
a) between the triton and non-triton implementations and
b) between multiple triton runs of the same script
This PR resolves this by using the
restore_value
feature intriton.autotune
which restores the values back after autotuning completes. And thereby avoids the issues of in-place modification.