Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): add letter-text icon #2252

Merged
merged 5 commits into from
Jul 20, 2024

Conversation

GRA0007
Copy link
Contributor

@GRA0007 GRA0007 commented Jun 24, 2024

Closes #1676

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Adds a letter-text icon.

Icon use case

  • Inserting a drop cap into a rich text editor
  • To indicate a letter in a paragraph of text

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in Dropcap Icon #1676 by @jguddas
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
oliviertassinari Olivier Tassinari
Co-authored-by: Jakob Guddas <github@jguddas.de>
@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Jun 24, 2024
Copy link

github-actions bot commented Jun 24, 2024

Added or changed icons

icons/letter-text.svg

Preview cohesion icons/square-arrow-out-up-right.svg
icons/letter-text.svg
icons/user.svg
Preview stroke widths icons/letter-text.svg
icons/letter-text.svg
icons/letter-text.svg
DPI Preview (24px) icons/letter-text.svg
Icon X-rays icons/letter-text.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const LetterTextIcon = createLucideIcon('LetterText', [
  ["path",{"d":"M15 12h6"}],
  ["path",{"d":"M15 6h6"}],
  ["path",{"d":"m3 13 3.553-7.724a.5.5 0 0 1 .894 0L11 13"}],
  ["path",{"d":"M3 18h18"}],
  ["path",{"d":"M4 11h6"}]
])

@GRA0007 GRA0007 changed the title feat(icons): add drop-cap icon feat(icons): add drop-cap icon Jun 24, 2024
Copy link
Member

@karsa-mistmere karsa-mistmere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jguddas
Copy link
Member

jguddas commented Jun 24, 2024

I think the name should be changed, drop-cap is not descriptive about what's inside the icon, but rather what it represents.

@GRA0007
Copy link
Contributor Author

GRA0007 commented Jun 25, 2024

@jguddas what would you recommend? letter-paragraph?

GRA0007 and others added 2 commits June 25, 2024 13:00
Co-authored-by: Jakob Guddas <github@jguddas.de>
@ericfennis
Copy link
Member

@GRA0007 Or letter-text?

@GRA0007
Copy link
Contributor Author

GRA0007 commented Jun 25, 2024

Yeah thanks @ericfennis, that sounds good

@GRA0007 GRA0007 changed the title feat(icons): add drop-cap icon feat(icons): add letter-text icon Jun 25, 2024
@GRA0007 GRA0007 requested a review from jguddas June 25, 2024 08:50
@karsa-mistmere karsa-mistmere merged commit 54a5888 into lucide-icons:main Jul 20, 2024
8 checks passed
@GRA0007 GRA0007 deleted the icon/drop-cap branch July 20, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropcap Icon
4 participants