Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added philippine-peso icon #2231

Merged
merged 25 commits into from
Jul 19, 2024

Conversation

kasutu
Copy link
Contributor

@kasutu kasutu commented Jun 18, 2024

closes #2230

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Icon use case

Represents the Philippine currency.

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in Philippine Peso Icon #2230 by @jguddas
  • I've based them on the following Lucide icons: russian-ruble, dollar-sign
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/philippine-peso.json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

Sorry, something went wrong.

kasutu added 2 commits June 19, 2024 03:57

Unverified

The signing certificate or its chain could not be verified.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Jun 18, 2024
Copy link

github-actions bot commented Jun 18, 2024

Added or changed icons

icons/philippine-peso.svg

Preview cohesion icons/square-mouse-pointer.svg
icons/philippine-peso.svg
icons/square-divide.svg
Preview stroke widths icons/philippine-peso.svg
icons/philippine-peso.svg
icons/philippine-peso.svg
DPI Preview (24px) icons/philippine-peso.svg
Icon X-rays icons/philippine-peso.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const PhilippinePesoIcon = createLucideIcon('PhilippinePeso', [
  ["path",{"d":"M20 11H4"}],
  ["path",{"d":"M20 7H4"}],
  ["path",{"d":"M7 21V4a1 1 0 0 1 1-1h4a1 1 0 0 1 0 12H7"}]
])

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@kasutu kasutu marked this pull request as ready for review June 19, 2024 05:10

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@kasutu
Copy link
Contributor Author

kasutu commented Jun 19, 2024

thank you @jguddas

kasutu added 2 commits June 19, 2024 16:52

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
reordered author
@karsa-mistmere
Copy link
Member

This feels disproportionately large compared to other currency icons:
image

@kasutu
Copy link
Contributor Author

kasutu commented Jun 19, 2024

This feels disproportionately large compared to other currency icons: image

yeah, will try to visually balance it or change style

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Jakob Guddas <github@jguddas.de>
kasutu added 3 commits June 19, 2024 21:07

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@jguddas
Copy link
Member

jguddas commented Jun 19, 2024

You need to not forget about the 2px gap rule.

@kasutu
Copy link
Contributor Author

kasutu commented Jun 19, 2024

Description of Image

made the gaps tight and the leg a little shorter matching the other symbols

@kasutu kasutu requested a review from jguddas June 19, 2024 13:13
@karsa-mistmere
Copy link
Member

Description of Image made the gaps tight and the leg a little shorter matching the other symbols

Unfortunately, this results in a guideline violation, there should be at least a 2px gap between all elements.

@kasutu
Copy link
Contributor Author

kasutu commented Jun 19, 2024

image

image
image

what do you think?

@kasutu
Copy link
Contributor Author

kasutu commented Jun 21, 2024

image

basically the feet was just a little bit longer. I Reduced it to match the Hight of other currency.

i just have doubts on the previous design that it might be misunderstood by the Filipino community

Co-authored-by: Jakob Guddas <github@jguddas.de>
@chessurisme
Copy link
Contributor

How cleverly this icon made! I am quite surprised about the result. 😉

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@ericfennis ericfennis merged commit fa6ddf9 into lucide-icons:main Jul 19, 2024
8 checks passed
@kasutu kasutu deleted the studio/philippine-peso branch August 18, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Philippine Peso Icon
5 participants