New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added pilcrow-right
icon
#1668
Conversation
Added or changed iconsIcons as codeOnly working for: const PilcrowRightIcon = createLucideIcon('PilcrowRight', [
["path",{"d":"M10 3v11"}],
["path",{"d":"M10 9H7a1 1 0 0 1 0-6h8"}],
["path",{"d":"M14 3v11"}],
["path",{"d":"m18 14 4 4H2"}],
["path",{"d":"m22 18-4 4"}]
]) |
The visual center is to the right of the geometric center so moving it is okay IMO |
@jguddas let me know if there's anything needed from my side. |
icons/pilcrow-right.svg
Outdated
stroke-linecap="round" | ||
stroke-linejoin="round" | ||
> | ||
<path d="M11 8.56H8.22a2.78 2.78 0 0 1 0-5.56h7.89M11 3v11M15 3v11M21 18H3M18 15l3 3-3 3" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like with the left shift, it's fine.
But shifting pilcrow-left to the left makes it feel quite left heavy.
<path d="M11 8.56H8.22a2.78 2.78 0 0 1 0-5.56h7.89M11 3v11M15 3v11M21 18H3M18 15l3 3-3 3" /> | |
<path d="M10 9H7a1 1 0 0 1 0-6h8" /> | |
<path d="M10 3v11" /> | |
<path d="M14 3v11" /> | |
<path d="M21 18H3" /> | |
<path d="m18 15 3 3-3 3" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work splitting up those paths, @jguddas
Also see #1667 (comment)
Unfortunately the pilcrow itself is off grid and hence appears pretty blurry:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a super big fan of the small pilcrow we already have, I think it looks pretty disproportionate, how about some alternate designs for this use case, such as: |
For the use case of text direction, it has to be based on pilcrow to make sense. |
@karsa-mistmere @jguddas We should keep the pillcrow.
Those languages don't use alphabetical characters. Also for RTL, this design is mostly used according to a quick search on Google. |
How about increase the size of the arrow, to match Previous version. |
I like the bigger arrow 👍 |
What is the purpose of this pull request?
pilcrow-left
)Description
a pilcrow with left arrow underneath it. Creating the sibling to this icon went smoothly #1667 but with the
pilcrow-right
there's an awkward closeness between the two shapes (see image below)And it's happening because I didn't want to move the pilcrow icon to the left so that it remains centered (based on my judgment).
Icon use case
To switch the direction to LTR
Mostly used in rich-text editors but can also be used to switch the viewing experience of a website to LTR
Alternative icon designs
This is an alternative to the
pilcrow-left
icon #1667Icon Design Checklist
Concept
Author, credits & license
This icon is using an adjust versions of
pilcrow-square
andmove-right
.Naming
icons/[iconName].json
.Design
Before Submitting