Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added pilcrow-left icon #1667

Merged
merged 12 commits into from Apr 5, 2024
Merged

Conversation

zaaakher
Copy link
Contributor

@zaaakher zaaakher commented Nov 6, 2023

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Icon use case

To switch the direction to RTL
Mostly used in rich-text editors but can also be used to switch the viewing experience of a website to RTL (similar to how mantine does in their website header.

Most Common RTL Languages:
(Arabic, Persian, Urdu, Kashmiri, Pashto, Uighur, Hebrew, Sorani Kurdish, and Sindhi)

Alternative icon designs

I will be creating another PR for pilcrow-right with a move-right arrow but there's small caveat that will be mentioned in that PR.

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

This icon is using an adjust versions of pilcrow-square and move-left. The following image shows the adjustments made
image

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to two points of precision.

Before Submitting

Copy link

github-actions bot commented Nov 6, 2023

Added or changed icons

icons/pilcrow-left.svg

Preview cohesion icons/message-square-warning.svg
icons/pilcrow-left.svg
icons/square-arrow-right.svg
Preview stroke widths icons/pilcrow-left.svg
icons/pilcrow-left.svg
icons/pilcrow-left.svg
DPI Preview (24px) icons/pilcrow-left.svg
Icon X-rays icons/pilcrow-left.svg

Icons as code

Only working for:
lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const PilcrowLeftIcon = createLucideIcon('PilcrowLeft', [
  ["path",{"d":"M14 3v11"}],
  ["path",{"d":"M14 9h-3a3 3 0 0 1 0-6h9"}],
  ["path",{"d":"M18 3v11"}],
  ["path",{"d":"M22 18H2l4-4"}],
  ["path",{"d":"m6 22-4-4"}]
])

@github-actions github-actions bot added 📖 documentation Improvements or additions to documentation 🎨 icon About new icons 🌍 site Has to do something with the Lucide website 🫧 metadata Improved metadata labels Nov 6, 2023
@github-actions github-actions bot removed 📖 documentation Improvements or additions to documentation 🌍 site Has to do something with the Lucide website labels Nov 6, 2023
@zaaakher
Copy link
Contributor Author

zaaakher commented Nov 6, 2023

My apologies for the inconvenience, it somehow included my other PR into this branch as well. It's been years and I still haven't grasped using git properly especially when it comes to PR's and contributing to open source.

@zaaakher zaaakher mentioned this pull request Nov 7, 2023
23 tasks
@zaaakher zaaakher changed the title feat: added pilcrow-left icon feat: added pilcrow-left icon Nov 7, 2023
@karsa-mistmere
Copy link
Member

This icon is using an adjust versions of pilcrow-square and move-left. The following image shows the adjustments made image

I'm not quite sure how this overlay was made, but there is a much more significant difference between pilcrow-square's pilcrow (in red), and this:
image

These alterations are not pixel perfect, so they would appear super blurry on low-res screens:
image

@github-actions github-actions bot added the Stale label Dec 10, 2023
@github-actions github-actions bot removed the Stale label Jan 3, 2024
@ericfennis ericfennis merged commit 52de557 into lucide-icons:main Apr 5, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants