fix(animations): make inner views animated only when necessary #117
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we turn off the
swipeToDismiss
functionality, the inner views (and the whole bottom sheet) are always animated, no matter what values change.This is because of
self.configuration
property (which is configured to trigger an animation) always returningfalse
for the equality function==
.It seems like a mistake in the equality function, where it accidentally checks for both
lhs.isSwipeToDismissEnabled
andrhs.isSwipeToDismissEnabled
instead of just comparing them to each other (and they returnfalse
because we turned off theswipeToDismiss
functionality).