Config.read_config_file - use safe_load_file if available #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Psych 4+ may change load_file behavior
MSP-Greg
added a commit
to MSP-Greg/yard
that referenced
this pull request
Jun 13, 2022
… fixed?)" This reverts commit a80a728. Fixed by PR lsegal#1385
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Psych 4+ may change load_file behavior. Noticed this issue running YARD with Ruby master/main/head build, as it recently crashed.
Also, using
Psych.safe_load_filewhen available is probably better from a security standpoint...Completed Tasks
bundle exec rakelocally (if code is attached to PR) and ran CI in my fork.