-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support CommonMark via commonmarker markup provider #1157
Comments
|
A PR to add |
@lsegal I would be proud to help but I'm not a experienced dev, in fact I'm not a dev at all. I always make a PR when I'm able to; but here I don't know how to add the support for commonmarker. Update: sorry I didn't read / remember this before https://github.com/lsegal/yard/blob/master/CONTRIBUTING.md#asking-for-a-feature. Do I need to join the mailing list to ask everyone how to properly implement this? |
Sorry for the late reply: You're free to ask on the mailing list if you need more info. You can also look at https://github.com/lsegal/yard/blob/master/lib/yard/templates/helpers/markup_helper.rb where markup libs are defined and play around with those definitions. |
I'm interested in providing a pull request to refactor the markup provider loading code to make it easier to:
|
The issue Render: 2 vs 4 white spaces in markdown lists #1155 was the fault of redcarpet not of yard or github_markup as you can read in github/markup#1142.
For a ton of reason readcarpet is not doing the thing the right way, and that's why now GitHub and their GFM use commonmark standard for their GFM specs. Ref. here.
As you can see there are lot of markdown issues specifically due to readcarpet like issue #1032 or #1155.
That's why a lot of big and serious project (like github-markup used by github.com and a lot more) now use only commonmarker (repo) that respect CommonMark markdown. Any other way will lead to hazardous random due to unclear / ambiguous specs.
That's why I ask for yard to use github-markup / commonmarker by default instead of github-markup / redcarpet and a least to add commonmarker in the markup providers to allow using the
--markup-provider
switch.Even before commonmarker was heavily used a lot of projects deprecated the use of RDiscount, Redcarpet, or RedCloth for kramdown.
Steps to reproduce
For example see #1155 for bad rendering with redcarpet.
Actual Output
--markup-provider commonmarker
withyard doc
is giving:because commonmarker is not in the markup providers.
I have read the Contributing Guide.
The text was updated successfully, but these errors were encountered: