Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce dependency (axum) #115

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Reduce dependency (axum) #115

merged 1 commit into from
Jan 9, 2025

Conversation

hirofumi
Copy link
Contributor

Would it be possible to enable tonic's channel feature instead of transport feature? transport feature depends on axum (via server feature and router feature) and it seems to be unnecessary for gcp-bigquery-client.

The features of tonic are as follows.

[features]
codegen = ["dep:async-trait"]
gzip = ["dep:flate2"]
zstd = ["dep:zstd"]
default = ["transport", "codegen", "prost"]
prost = ["dep:prost"]
tls = ["dep:rustls-pemfile", "dep:tokio-rustls", "dep:tokio", "tokio?/rt", "tokio?/macros"]
tls-roots = ["tls-native-roots"] # Deprecated. Please use `tls-native-roots` instead.
tls-native-roots = ["tls", "channel", "dep:rustls-native-certs"]
tls-webpki-roots = ["tls", "channel", "dep:webpki-roots"]
router = ["dep:axum", "dep:tower", "tower?/util"]
server = [
  "router",
  "dep:async-stream",
  "dep:h2",
  "dep:hyper", "hyper?/server",
  "dep:hyper-util", "hyper-util?/service", "hyper-util?/server-auto",
  "dep:socket2",
  "dep:tokio", "tokio?/macros", "tokio?/net", "tokio?/time",
  "tokio-stream/net",
  "dep:tower", "tower?/util", "tower?/limit",
]
channel = [
  "dep:hyper", "hyper?/client",
  "dep:hyper-util", "hyper-util?/client-legacy",
  "dep:tower", "tower?/balance", "tower?/buffer", "tower?/discover", "tower?/limit", "tower?/util",
  "dep:tokio", "tokio?/time",
  "dep:hyper-timeout",
]
transport = ["server", "channel"]

https://github.com/hyperium/tonic/blob/v0.12.3/tonic/Cargo.toml#L25-L54

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@lquerel
Copy link
Owner

lquerel commented Dec 30, 2024

I will include this PR in the next release. Thanks

@lquerel lquerel merged commit b9ddad8 into lquerel:main Jan 9, 2025
2 of 3 checks passed
@lquerel
Copy link
Owner

lquerel commented Jan 12, 2025

FYI, the version 0.25.0 (including your PR) has been published on crates.io. Thanks

@hirofumi
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants