Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2023-26136 in tough-cookie #632

Closed
Sher-Chowdhury opened this issue Sep 26, 2023 · 3 comments · Fixed by #701
Closed

CVE-2023-26136 in tough-cookie #632

Sher-Chowdhury opened this issue Sep 26, 2023 · 3 comments · Fixed by #701
Labels

Comments

@Sher-Chowdhury
Copy link

Sher-Chowdhury commented Sep 26, 2023

Description/Steps to reproduce

Found the following CVE for tough-cookie:

CVE-2023-26136 (severity: Medium)

$ npm list tough-cookie
strong-soap@3.5.5
└─┬ request@2.88.2
  └── tough-cookie@2.5.0

Additional info in salesforce/tough-cookie#282

Versions of the package tough-cookie before 4.1.3 are vulnerable to Prototype Pollution due to improper handling of Cookies when using CookieJar in rejectPublicSuffixes=false mode. This issue arises from the manner in which the objects are initialized.

Link to reproduction sandbox

Expected result

Additional information

@NewEraCracker
Copy link

NewEraCracker commented Oct 25, 2023

Some magic bits for package.json as a workaround:

  "overrides": {
    "request": "npm:@cypress/request@^3.0.1",
    "tough-cookie": "^4.1.3"
  },

My two cents, and hoping it helps.

This was referenced Feb 16, 2024
@toddtarsi
Copy link
Contributor

PR implementing a fix is here:

#701

@achrinza achrinza linked a pull request Feb 16, 2024 that will close this issue
2 tasks
@achrinza
Copy link
Member

Closed by #701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants