Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if perfomance has timing property #449

Merged

Conversation

haedaal
Copy link
Contributor

@haedaal haedaal commented Sep 13, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

nodejs/node#28635

performance became a global variable on node 16, but it does not have timing property.
and it's throwing following error.

I think this fix does not worth comments so I omitted examples and credit.

> m = require('./microtime')
[Function: microtime]
> m()
Uncaught TypeError: Cannot read properties of undefined (reading 'navigationStart')
    at microtime (.../locutus/src/php/datetime/microtime.js:17:51)

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@kukawski kukawski merged commit 6a93259 into locutusjs:master Sep 15, 2021
@kukawski
Copy link
Collaborator

@haedaal thank you for the fix.

@meirkeller
Copy link

@kukawski When are you going to release a version with this fix?

@kukawski
Copy link
Collaborator

@kvz could you please handle the release? We should probably also figure out automatic publishing.

@haedaal haedaal deleted the hotfix/node-v16-global-performance branch January 26, 2022 15:21
@kvz
Copy link
Collaborator

kvz commented Jan 27, 2022

@kvz could you please handle the release?

👍 + locutus@2.0.16

We should probably also figure out automatic publishing.

That would be great, as time passes my bandwidth for this project seems to decrease I'm afraid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants