Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code listing on locutus website #379

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Fix code listing on locutus website #379

merged 1 commit into from
Oct 11, 2018

Conversation

kukawski
Copy link
Collaborator

When reimplementing utils to use esprima, a line that was needed for displaying code on locutus website was accidentally commented out.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@kukawski kukawski requested a review from kvz October 10, 2018 19:06
@kvz kvz merged commit dd54a25 into master Oct 11, 2018
@kvz kvz deleted the issue-376-patch branch October 11, 2018 06:35
@kvz
Copy link
Collaborator

kvz commented Oct 11, 2018

Thanks!!

@kukawski
Copy link
Collaborator Author

@kvz do you plan to re-build the website?

@kvz
Copy link
Collaborator

kvz commented Oct 16, 2018

That happens automatically (https://travis-ci.org/kvz/locutus/jobs/439996587#L4877), i'm afraid the pr didn't fix it

@kukawski
Copy link
Collaborator Author

Weird, because locally it seems to work for me. I didn't run the full website generation scripts, just concentrated on npm run injectweb. Without this fix it generates

{% codeblock lang:javascript %}undefined{% endcodeblock %}

with the fix, the codeblock contains the function's source code.

@kvz
Copy link
Collaborator

kvz commented Oct 17, 2018 via email

@kukawski
Copy link
Collaborator Author

Have you tried the manual deployment?

@kvz
Copy link
Collaborator

kvz commented Oct 23, 2018

Sorry to keep you waiting! I did just now and that seemed to have fixed it! Removed --silent from deploys. Hopefully we'll then be able to spot if there is an issue by running them on Travis.

@kvz
Copy link
Collaborator

kvz commented Oct 23, 2018

Thanks for fixing this @kukawski! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants