Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "[ThinLTO] Populate declaration import status except for distributed ThinLTO under a default-off new option" #92716

Conversation

minglotus-6
Copy link
Contributor

TODO: fix build-bot failure (maybe set thinlto-threads to 1)

Original Commit Message:

The goal is to populate declaration import status if a new flag -import-declaration is on.

  • For in-process ThinLTO, the declaration status is visible to backend function-import pass, so FunctionImporter::importFunctions should read the import status and be no-op for declaration summaries. Basically, the postlink pipeline is updated to keep its current behavior (import definitions), but not updated to handle declaration summaries. Two use cases (better call-graph sort or cross-module auto-init) would use this bit differently.

  • For distributed ThinLTO, the declaration status is not serialized to bitcode. As discussed, [ThinLTO][Bitcode] Generate import type in bitcode #87600 will do this.

@minglotus-6
Copy link
Contributor Author

Will create PR from branch 'users/minglotus-6/spr/summary2' to keep commit history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant