Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace in comments gets mangled and sometimes deleted #6

Closed
haltman-at opened this issue Feb 1, 2023 · 2 comments
Closed

Whitespace in comments gets mangled and sometimes deleted #6

haltman-at opened this issue Feb 1, 2023 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@haltman-at
Copy link

haltman-at commented Feb 1, 2023

If I do parse("#abc def ghi"), instead of [{ comment: "abc def ghi" }], the result is [{ comment: "abcdef ghi" }].

(Tested with shell-quote version 1.8.0.)

@ljharb
Copy link
Owner

ljharb commented Feb 1, 2023

This seems pretty expected on a shell - multiple space separators get collapsed into one, i think? or are you saying because it's a comment you expect them to be preserved?

@haltman-at
Copy link
Author

Yeah, I would expect the comment field to contain the exact text of the comment. Like there shouldn't be any parsing being applied to the text of a comment!

@ljharb ljharb added bug Something isn't working help wanted Extra attention is needed labels Feb 1, 2023
@ljharb ljharb closed this as completed in ecf2a60 Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants