Handle stringifying empty objects with addQueryPrefix #217
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stringifying an empty object would produce a string such as '?'. With this fix, we output an empty line instead.
|
(This is a patch because the original feature has never been released; otherwise, it'd be a semver-major) |
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting PR as agreed, this should fix the issue described in #213:
Stringifying an empty object would produce a string such as '?'. With
this fix, we output an empty string instead.
Sorry about increasing complexity and max-statements in
.eslintrc,I didn't see a quick way to reduce complexity.
Thanks for this great library 👍