From 75f0fbc5c664f334da9f2048c17b8fd7516a0f17 Mon Sep 17 00:00:00 2001 From: Andreas Lind Date: Fri, 27 Jul 2018 00:09:13 +0200 Subject: [PATCH] Avoid arr = arr.concat(...), push to the existing instance --- lib/stringify.js | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/lib/stringify.js b/lib/stringify.js index 4015b785..d3130bd8 100644 --- a/lib/stringify.js +++ b/lib/stringify.js @@ -15,6 +15,14 @@ var arrayPrefixGenerators = { } }; +var pushToArray = function (arr, valueOrArray) { + if (Array.isArray(valueOrArray)) { + Array.prototype.push.apply(arr, valueOrArray); + } else { + arr.push(valueOrArray); + } +}; + var toISO = Date.prototype.toISOString; var defaults = { @@ -93,7 +101,7 @@ var stringify = function stringify( // eslint-disable-line func-name-matching } if (Array.isArray(obj)) { - values = values.concat(stringify( + pushToArray(values, stringify( obj[key], generateArrayPrefix(prefix, key), generateArrayPrefix, @@ -109,7 +117,7 @@ var stringify = function stringify( // eslint-disable-line func-name-matching charset )); } else { - values = values.concat(stringify( + pushToArray(values, stringify( obj[key], prefix + (allowDots ? '.' + key : '[' + key + ']'), generateArrayPrefix, @@ -200,8 +208,7 @@ module.exports = function (object, opts) { if (skipNulls && obj[key] === null) { continue; } - - keys = keys.concat(stringify( + pushToArray(keys, stringify( obj[key], key, generateArrayPrefix,