From 4df46088849e66c4ebb47e83536a064bd4dbb3c6 Mon Sep 17 00:00:00 2001 From: Andreas Lind Date: Fri, 27 Jul 2018 00:09:13 +0200 Subject: [PATCH] Avoid arr = arr.concat(...), push to the existing instance --- lib/stringify.js | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/lib/stringify.js b/lib/stringify.js index ab915ac4..760d964d 100644 --- a/lib/stringify.js +++ b/lib/stringify.js @@ -15,6 +15,14 @@ var arrayPrefixGenerators = { } }; +var pushToArray = function (arr, valueOrArray) { + if (Array.isArray(valueOrArray)) { + Array.prototype.push.apply(arr, valueOrArray); + } else { + arr.push(valueOrArray); + } +}; + var toISO = Date.prototype.toISOString; var defaults = { @@ -86,7 +94,7 @@ var stringify = function stringify( // eslint-disable-line func-name-matching } if (Array.isArray(obj)) { - values = values.concat(stringify( + pushToArray(values, stringify( obj[key], generateArrayPrefix(prefix, key), generateArrayPrefix, @@ -101,7 +109,7 @@ var stringify = function stringify( // eslint-disable-line func-name-matching encodeValuesOnly )); } else { - values = values.concat(stringify( + pushToArray(values, stringify( obj[key], prefix + (allowDots ? '.' + key : '[' + key + ']'), generateArrayPrefix, @@ -186,8 +194,7 @@ module.exports = function (object, opts) { if (skipNulls && obj[key] === null) { continue; } - - keys = keys.concat(stringify( + pushToArray(keys, stringify( obj[key], key, generateArrayPrefix,