Handle the rate limit exceeding error #71
Conversation
bin/can-merge
Outdated
| console.error(`API Points: used - ${response.rateLimit.cost}\tremaining - ${response.rateLimit.remaining}`); | ||
| } | ||
|
|
||
| process.stderr.write(`API Points: used - ${response.rateLimit.cost}\tremaining - ${response.rateLimit.remaining}\n`); |
There was a problem hiding this comment.
i think console.error should remain here; it plays more nicely with the shell output than process.stderr.write
There was a problem hiding this comment.
Oh ok! I think I made an error with the closing brackets as well😥
utils/watch.js
Outdated
| setTimeout(() => { | ||
| process.stderr.write('.'); | ||
| }, milliSecondsLeft); |
There was a problem hiding this comment.
this just writes a dot, milliSecondsLeft later. it seems like maybe you want await delay(millisecondsLeft), where delay is async function delay(ms) { return new Promise((resolve) => setTimeout(resolve, ms)); }?
MaheraFurniturewala
force-pushed
the
issue51
branch
from
c202359
to
b32601c
Compare
| const secondsLeft = Math.ceil(milliSecondsLeft / 1000); | ||
|
|
||
| if ((remAPIPoints < lastReqCost) && (retryDelay < milliSecondsLeft)) { | ||
| process.stderr.write(`API points exhausted. Command will run after ${secondsLeft} seconds\n\n`); |
There was a problem hiding this comment.
if it's going to write a newline, can it use console.error?
|
not sure what happened here |
Fixes #51