Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin ignores versions declared with "strictly" #95

Closed
aintogarov opened this issue Dec 14, 2022 · 2 comments · Fixed by #106
Closed

Plugin ignores versions declared with "strictly" #95

aintogarov opened this issue Dec 14, 2022 · 2 comments · Fixed by #106

Comments

@aintogarov
Copy link

VersionCatalogParser doesn't handle strict versions. For example

kotlin = { strictly = "1.7.21" }

However com.github.ben-manes.versions takes such versions into account and writes them to output.

@hvisser
Copy link
Contributor

hvisser commented Dec 14, 2022

Can you elaborate and provide a sample project?

For versions like this I think there should be a message logged, but no upgrades will be performed, since you've specified that you want to use this exact version.

So if you don't see that message, this might be a bug.

@hvisser
Copy link
Contributor

hvisser commented Dec 20, 2022

OK I checked and the warning that is in place for libraries is not implemented for plugins (because it's slightly more complicated 😅 ) so I assume that is what this issue is about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants