Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version grouping can be more agressive #127

Closed
hvisser opened this issue Dec 22, 2023 · 0 comments · Fixed by #128
Closed

Version grouping can be more agressive #127

hvisser opened this issue Dec 22, 2023 · 0 comments · Fixed by #128
Assignees

Comments

@hvisser
Copy link
Contributor

hvisser commented Dec 22, 2023

Describe the issue
When multiple artifacts in the same maven group have the same version, they should be grouped into a version reference if possible. However, this grouping does not always happen if there are artifacts in the same group that have a different version.

Steps to reproduce
Given this TOML file:

[libraries]
camerax-camera2 = "androidx.camera:camera-camera2:1.3.1"
camerax-core = "androidx.camera:camera-core:1.3.1"
camerax-lifecycle = "androidx.camera:camera-lifecycle:1.3.1"
camerax-mlkit = "androidx.camera:camera-mlkit-vision:1.4.0-alpha03"
camerax-view = "androidx.camera:camera-view:1.3.1"

Ideally this would create a new version 1.3.1 for all of the androidx.camera artifacts that match this version. But when applying this to a project, there's no grouping because (apparently) the 1.4.0-alpha03 version is picked as the grouping version and since that's only one library, none of the libraries get grouped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant