Add fast path for noopTransformer
#37
Merged
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `transform.Nop` makes a copy of the input causing allocations. We optimise this by creating our own nop transformer that does nothing and give it a fast path that just returns the original string. This means that the regular `Match(source, target)` case we go from 2 to 0 allocations which comes with quite significant speed improvements. v1.1.3: BenchmarkMatch-8 6939124 170.5 ns/op 512 B/op 2 allocs/op BenchmarkMatchBigLate-8 621099 1796 ns/op 512 B/op 2 allocs/op BenchmarkMatchBigEarly-8 2873862 413.7 ns/op 512 B/op 2 allocs/op HEAD: BenchmarkMatch-8 58240472 20.66 ns/op 0 B/op 0 allocs/op BenchmarkMatchBigLate-8 896416 1298 ns/op 0 B/op 0 allocs/op BenchmarkMatchBigEarly-8 72513230 16.62 ns/op 0 B/op 0 allocs/op
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
transform.Nopmakes a copy of the input causing allocations. We optimise this by creating our own nop transformer that does nothing and give it a fast path that just returns the original string.This means that the regular
Match(source, target)case we go from 2 to 0 allocations which comes with quite significant speed improvements.Fixes #36