-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MySQL boolean behaviour from TinyInt(1) to TinyInt #5130
Conversation
Kudos, SonarCloud Quality Gate passed! |
Possibly there could be some test harness failures (I searched through code, I guess should be fine), but we can't check until we merge, since test-harness execution is broken currently. |
Yeap, test harness will fail but I have created this PR for that which I'll ask interop team to merge it when have this one merged. |
oh,nice! I have not found anything related to TinyInt(1) cause I have an old repo state...Thanks Daniel! |
I know this is already merged so I should probably create a proper issue for it, but the mysql jdbc driver can convert between TINYINT(1) and BOOLEAN automatically. This is because boolean is an alias for tinyint(1) in mysql. |
Impact
Description
Starting from 8.0.17, MySQL shows a warning (
"Integer display width is deprecated and will be removed in a future release"
) when directly using tinyint(1), instead of tinyint. So, here we are updating BooleanType class to address this change.Fixes #5069
Things to be aware of
Things to worry about
Additional Context