Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking node support in minor update #1304

Closed
RyanofWoods opened this issue Jun 30, 2023 · 1 comment · Fixed by #1289
Closed

Breaking node support in minor update #1304

RyanofWoods opened this issue Jun 30, 2023 · 1 comment · Fixed by #1289

Comments

@RyanofWoods
Copy link

Description

During the #1265 PR, a dependency update commit was made, which was released into v13.2.0-v13.2.3.

Namely it bumped execa from 6.1.0 to 7.0.0.

This is a breaking change and means a loss of support for node 14.13.1 - 14.17.0 and 16.0.0 - 16.3.0.
https://github.com/sindresorhus/execa/releases/tag/v7.0.0

Now, the package.json engine versions are no longer in sync with the actual supported versions:
https://github.com/okonet/lint-staged/blob/66a716d5a32c49f03b9a34350fec1b2411bada17/package.json#L17

I would recommend:

  • updating the release log to indicate this for other developers;
  • updating the package.json;
  • possibly shifting dependencies bumps to major versions in the future.

Steps to reproduce

  1. Create a repo with yarn;
  2. Use a node version of 16.13.0
  3. Add lint-staged of 13.2+ to package.json
  4. Run yarn install
Installing using Yarn
yarn install v1.22.18
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
error execa@7.1.1: The engine "node" is incompatible with this module. Expected version "^14.18.0 || ^16.14.0 || >=18.0.0". Got "16.13.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Exited with code exit status 1

Environment

  • OS: MacBook M1 Pro - Ventura 13.4.1 (22F82)
  • Node.js: 16.13.0
  • lint-staged: 13.2.3
@iiroj
Copy link
Member

iiroj commented Jun 30, 2023

Thanks for the issue! This seems to be an oversight that I didn't realize.

There's already an MR that will update other deps that have dropped 14 support and solve this. It'll be a major version bump for lint-staged: #1289

FYI @okonet

@iiroj iiroj linked a pull request Jun 30, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants