test: add release info to xml file before uploading to obj storage #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykim-1
requested review from
lgarber-akamai,
vshanthe and
zliang-akamai
and removed request for
a team
lgarber-akamai
approved these changes
Dec 6, 2023
| @@ -1,11 +1,38 @@ | |||
| import argparse | |||
There was a problem hiding this comment.
Side note: Given we re-use these scripts in a bunch of DX-maintained repos, I wonder if it would make sense to move them into their own repo and pull them into each implementation using submodules.
There was a problem hiding this comment.
I think that's a good idea if these scripts are identical.
There was a problem hiding this comment.
Yeah that is a good idea, only thing different is the latest_release_url which can be a list or an array that can be selected based on the repo. I can create some tickets to address this.
Co-authored-by: Lena Garber <114949949+lgarber-akamai@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Problem: For some context, the script that is used to upload test report from OBJ storage to TOD is currently calling GitHub API endpoints from ECP Test VM to get the release info for corresponding repository. However recently there has been a rate limiting issue that is causing an error calling endpoint from that particular VM. E.g.
Error: 403 Client Error: rate limit exceeded for url: https://api.github.com/repos/linode/terraform-provider-linode/releases/latest linode-terraform None✔️ How to Test
Monitor TOD after merged to dev
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.