Use mocks for TestInstanceStats_Get and TestObjectStorage_Cancel tests #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing verification and merging all commits (linode#347)
amisiorek-akamai
requested review from
lgarber-akamai and
zliang-akamai
and removed request for
a team
|
Can we create a unit test directory to hold all mocked tests or maybe making a |
|
I think we should make a new ticket for that, and maybe get Youjung's opinion on restructuring the test suite because I think mocks are scattered throughout the codebase at the moment. Thoughts? @zliang-akamai |
|
@amisiorek-akamai Ah yes, your are right, didn't realize that, lol |
zliang-akamai
approved these changes
Nov 17, 2023
lgarber-akamai
requested changes
Nov 17, 2023
Comment on lines
19
to
36
| CPU: [][]float64{}, | ||
| IO: linodego.StatsIO{ | ||
| IO: [][]float64{}, | ||
| Swap: [][]float64{}, | ||
| }, | ||
| NetV4: linodego.StatsNet{ | ||
| In: [][]float64{}, | ||
| Out: [][]float64{}, | ||
| PrivateIn: [][]float64{}, | ||
| PrivateOut: [][]float64{}, | ||
| }, | ||
| NetV6: linodego.StatsNet{ | ||
| In: [][]float64{}, | ||
| Out: [][]float64{}, | ||
| PrivateIn: [][]float64{}, | ||
| PrivateOut: [][]float64{}, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Could this be populated with some arbitrary data just to make sure everything unmarshals correctly?
lgarber-akamai
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摑 Description
Makes mocks for TestInstanceStats_Get and TestObjectStorage_Cancel such that we no longer have to skip those tests.
鉁旓笍 How to Test
make test SKIP_LINT=1 ARGS="-run TestInstanceStats_Get"make test SKIP_LINT=1 ARGS="-run TestObjectStorage_Cancel"