Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): rspack with lingui swc plugin #1923

Merged
merged 7 commits into from
Apr 25, 2024

Conversation

aseerkt
Copy link
Contributor

@aseerkt aseerkt commented Apr 19, 2024

Description

Replace babel-loader with builtin swc-loader of rspack
Screencast from 19-04-24 08:07:52 PM IST.webm

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes #1896

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 8:20am

Copy link

github-actions bot commented Apr 19, 2024

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.86 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.67 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.99%. Comparing base (d6b9698) to head (5b133a3).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1923      +/-   ##
==========================================
- Coverage   76.65%   75.99%   -0.66%     
==========================================
  Files          81       85       +4     
  Lines        2090     2108      +18     
  Branches      533      537       +4     
==========================================
  Hits         1602     1602              
- Misses        375      393      +18     
  Partials      113      113              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@thekip thekip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the example on my machine and it works with no issue. Thanks.

I left one comment regarding code formatting (we have prettier switched off for examples folder, so you need to format it manually)

Also, there is a paragraph in the Readme related to babel, it should be removed or changed to description that built-in loader is used in conjunction with lingui swc-plugin and you need to pick a right version of it.

examples/rspack/rspack.config.js Outdated Show resolved Hide resolved
Copy link
Contributor

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aseerkt thank you!

@andrii-bodnar andrii-bodnar merged commit eb50982 into lingui:main Apr 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rspack now supports wasm plugins, lingui integration example could be improved
3 participants