-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(examples): rspack with lingui swc plugin #1923
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1923 +/- ##
==========================================
- Coverage 76.65% 75.99% -0.66%
==========================================
Files 81 85 +4
Lines 2090 2108 +18
Branches 533 537 +4
==========================================
Hits 1602 1602
- Misses 375 393 +18
Partials 113 113 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the example on my machine and it works with no issue. Thanks.
I left one comment regarding code formatting (we have prettier switched off for examples
folder, so you need to format it manually)
Also, there is a paragraph in the Readme related to babel, it should be removed or changed to description that built-in loader is used in conjunction with lingui swc-plugin and you need to pick a right version of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aseerkt thank you!
Description
Replace babel-loader with builtin swc-loader of rspack
Screencast from 19-04-24 08:07:52 PM IST.webm
Types of changes
Fixes #1896
Checklist