Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): native support react RSC #1914

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

thekip
Copy link
Collaborator

@thekip thekip commented Apr 11, 2024

Description

Bring to the React package primitives for comfortable work with RSC

Related discussion: #1903 (comment)
Here is example using it: thekip/nextjs-lingui-rsc-poc#3

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2024 7:11am

Copy link

github-actions bot commented Apr 11, 2024

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.86 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.65 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

Copy link
Contributor

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thekip thank you!

@andrii-bodnar
Copy link
Contributor

@thekip let's ship it in v4?

@thekip thekip changed the base branch from next to main April 12, 2024 07:09
@thekip
Copy link
Collaborator Author

thekip commented Apr 12, 2024

Rebased and changed the base, this one #1915 is also important to be merged to make it work.

@andrii-bodnar
Copy link
Contributor

andrii-bodnar commented Apr 12, 2024

@thekip could you please rebase the #1915 as well? There are some e2e tests failing btw

@thekip
Copy link
Collaborator Author

thekip commented Apr 12, 2024

Just found that splitting macro to two packages not in the main branch, so the fix #1915 is not needed right now.

@thekip
Copy link
Collaborator Author

thekip commented Apr 12, 2024

Also i have completely no idea how to test changes from this PR. Probably the only one way is full e2e test on nextjs application using cypress/playwright

@andrii-bodnar
Copy link
Contributor

Probably this is the only way

@andrii-bodnar andrii-bodnar merged commit 0e94f2a into lingui:main Apr 12, 2024
5 checks passed
@thekip thekip deleted the feature/react-rsc branch April 12, 2024 08:44
@andrii-bodnar
Copy link
Contributor

@thekip I'd like to make a new 4.9.0 release. Is there anything that is required for this release?

@thekip
Copy link
Collaborator Author

thekip commented Apr 12, 2024

@andrii-bodnar please, go ahead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants