Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warnings about invalid dependencies on Windows #1828

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

bravo-kernel
Copy link
Contributor

@bravo-kernel bravo-kernel commented Jan 4, 2024

Description

The build emits warnings on Windows as described in detail at https://discord.com/channels/974702239358783608/974704045346394172/1141002196398391436.

This PR contains the fix described here https://discord.com/channels/974702239358783608/1136285611087626250/1141022716237987980.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes #1705.

After this fix, Windows no longer emits the warnings.

Tests are not affected.

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 11:23am

Copy link

github-actions bot commented Jan 4, 2024

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.81 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.67 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5548d26) 76.39% compared to head (e1d21dd) 76.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1828   +/-   ##
=======================================
  Coverage   76.39%   76.39%           
=======================================
  Files          81       81           
  Lines        2072     2072           
  Branches      529      529           
=======================================
  Hits         1583     1583           
  Misses        377      377           
  Partials      112      112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-bodnar
Copy link
Contributor

@bravo-kernel thank you! How about adding tests as it was mentioned in the discord thread?

@bravo-kernel
Copy link
Contributor Author

@andrii-bodnar, those comments about (restructuring tests) read as optional/nice-to-have to me.

if tests is passing, and webpack don't complain on windows, this would be enough
If you can, it would be nice to remove "skipOnWindows"

Do you feel they are mandatory changes?

@andrii-bodnar
Copy link
Contributor

@bravo-kernel ok, nice to have

@andrii-bodnar andrii-bodnar merged commit 5f07937 into lingui:main Jan 4, 2024
17 checks passed
@bravo-kernel
Copy link
Contributor Author

Thank you for merging, I will give restructuring of the tests a try.

@bravo-kernel bravo-kernel deleted the fix-for-windows branch January 4, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid dependencies have been reported by plugins or loaders for this module.
2 participants