remove lindera_dictionary "build.rs"-only code/deps from full crate
#459
+22
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…across all crates This adjusts all the Cargo.toml's so that `reqwest` doesn't end up in the dependency tree of downstream consumers
|
|
|
@eeeebbbbrrrr |
|
Thanks for merging it, @mosuka! And thanks for Lindera! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
We (https://github.com/paradedb/paradedb/) have a dependency on the top-level
linderacrate and noticed that our project's dependency tree was pulling in other crates we don't use, such asreqwestandtokio(and many others).After some
cargo treeanalysis we realized it was coming fromlindera-dictionary-- specifically its "assets" module.It turns out that "assets" is only used by Lindera Dictionary's
build.rs, so...This PR introduces a new feature flag for
lindera-dictionaryso the other Lindera crates can toggle this newbuild_rsfeature flag only for their "build dependency" onlindera-dictionary.Ultimately, this removes (at least)
reqwestand all its dependencies, which was our goal.There's probably a few different ways this could be accomplished, and I'm happy to rework this PR in any way that y'all deem correct for the Lindera project. I really just wanted to put this in front of y'all. It's a big bonus for us not to have these unused crates as part of our compiled library and runtime.