Avoid writing ChannelManager when hitting lnd bug 6039
#2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failure: ln::shutdown_tests::test_lnd_bug_6039 |
When we hit lnd bug 6039, we end up sending error messages to peers in a loop. This should be fine, but because we used the generic `PersistenceNotifierGuard::notify_on_drop` lock above the specific handling, we end up writing `ChannelManager` every time we manage a round-trip to our peer. This can add up quite quickly, and isn't actually changing, so we really need to avoid writing the `ChannelManager` in this case.
TheBlueMatt
force-pushed
the
2024-03-no-wake-on-shutdown
branch
from
dadd363
to
03425e4
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2937 +/- ##
==========================================
- Coverage 89.20% 89.20% -0.01%
==========================================
Files 117 117
Lines 95513 95522 +9
Branches 95513 95522 +9
==========================================
+ Hits 85203 85209 +6
- Misses 7822 7831 +9
+ Partials 2488 2482 -6 ☔ View full report in Codecov by Sentry. |
G8XSU
approved these changes
Mar 14, 2024
| @@ -9242,8 +9242,6 @@ where | |||
| } | |||
|
|
|||
| fn handle_error(&self, counterparty_node_id: &PublicKey, msg: &msgs::ErrorMessage) { | |||
| let _persistence_guard = PersistenceNotifierGuard::notify_on_drop(self); | |||
|
|
|||
| match &msg.data as &str { | |||
| "cannot co-op close channel w/ active htlcs"| | |||
| "link failed to shutdown" => | |||
There was a problem hiding this comment.
unrelated: is it safe to rely on these string messages?
There was a problem hiding this comment.
In the worst case lnd changes the messages and we force-close instead of sending a repeated shutdown, so...it should be?
valentinewallace
approved these changes
Mar 14, 2024
wpaulino
approved these changes
Mar 14, 2024
This was referenced Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we hit lnd bug 6039, we end up sending error messages to peers in a loop. This should be fine, but because we used the generic
PersistenceNotifierGuard::notify_on_droplock above the specific handling, we end up writingChannelManagerevery time we manage a round-trip to our peer.This can add up quite quickly, and isn't actually changing, so we really need to avoid writing the
ChannelManagerin this case.