Add error handling for channels which fail to be created in funding_transaction_generated_intern
#2843
Milestone
Comments
TheBlueMatt
added a commit
to TheBlueMatt/rust-lightning
that referenced
this issue
Apr 29, 2024
In `funding_transaction_generated_intern`, if `find_funding_output` fails (e.g. due to the require output not being present in the provided funding transaction) we'd previously not generated a `ChannelClosed` event which leaves users possibly in a confused state. Here we fix this, also fixing the relevant tests to check for the new event. Fixes lightningdevkit#2843.
TheBlueMatt
added a commit
to TheBlueMatt/rust-lightning
that referenced
this issue
Apr 29, 2024
In `funding_transaction_generated_intern`, if `find_funding_output` fails (e.g. due to the require output not being present in the provided funding transaction) we'd previously not generated a `ChannelClosed` event which leaves users possibly in a confused state. Here we fix this, also fixing the relevant tests to check for the new event. Fixes lightningdevkit#2843.
TheBlueMatt
added a commit
to TheBlueMatt/rust-lightning
that referenced
this issue
Apr 29, 2024
In `funding_transaction_generated_intern`, if `find_funding_output` fails (e.g. due to the require output not being present in the provided funding transaction) we'd previously not generated a `ChannelClosed` event which leaves users possibly in a confused state. Here we fix this, also fixing the relevant tests to check for the new event. Fixes lightningdevkit#2843.
TheBlueMatt
added a commit
to TheBlueMatt/rust-lightning
that referenced
this issue
Apr 29, 2024
In `funding_transaction_generated_intern`, if `find_funding_output` fails (e.g. due to the require output not being present in the provided funding transaction) we'd previously not generated a `ChannelClosed` event which leaves users possibly in a confused state. Here we fix this, also fixing the relevant tests to check for the new event. Fixes lightningdevkit#2843.
TheBlueMatt
added a commit
to TheBlueMatt/rust-lightning
that referenced
this issue
Apr 30, 2024
In `funding_transaction_generated_intern`, if `find_funding_output` fails (e.g. due to the require output not being present in the provided funding transaction) we'd previously not generated a `ChannelClosed` event which leaves users possibly in a confused state. Here we fix this, also fixing the relevant tests to check for the new event. Fixes lightningdevkit#2843.
jbesraa
pushed a commit
to jbesraa/rust-lightning
that referenced
this issue
May 4, 2024
In `funding_transaction_generated_intern`, if `find_funding_output` fails (e.g. due to the require output not being present in the provided funding transaction) we'd previously not generated a `ChannelClosed` event which leaves users possibly in a confused state. Here we fix this, also fixing the relevant tests to check for the new event. Fixes lightningdevkit#2843.
adi2011
pushed a commit
to adi2011/rust-lightning
that referenced
this issue
May 6, 2024
In `funding_transaction_generated_intern`, if `find_funding_output` fails (e.g. due to the require output not being present in the provided funding transaction) we'd previously not generated a `ChannelClosed` event which leaves users possibly in a confused state. Here we fix this, also fixing the relevant tests to check for the new event. Fixes lightningdevkit#2843.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently it just returns the error, which can cause missing error handling at least in batch handling. See #2841 (comment)
The text was updated successfully, but these errors were encountered: