Move CandidateRouteHop enum variant fields into structs
#2802
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2802 +/- ##
==========================================
- Coverage 88.45% 88.45% -0.01%
==========================================
Files 114 114
Lines 91814 91912 +98
Branches 91814 91912 +98
==========================================
+ Hits 81218 81304 +86
- Misses 8103 8107 +4
- Partials 2493 2501 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
The code changes look great, and as far as the code changes go, the PR looks good to me.
But I am super curious about the issue this PR is solving.
The bindings generator struggles a bit with the references in enum variant fields in
CandidateRouteHop.
Would love to know more about how you found this issue and pinpointed its source.
Thanks a lot!
The bindings generator struggles a bit with the references in enum variant fields in `CandidateRouteHop`. While we could probably fix this, its much eaiser (and less risky) to inline the enum variant fields from `CandidateRouteHop` into structs. This also lets us make some of the fields non-public, which seems better at least for the opaque `hint_idx` in the blinded paths.
TheBlueMatt
force-pushed
the
2023-12-no-pub-enum
branch
from
cfafdce
to
3c28767
Compare
|
Gonna go ahead and land this cause its just pretty straightforward code motion and we'll want it for bindings either now or later. |
The bindings generator struggles a bit with the references in enum variant fields in
CandidateRouteHop. While we could probably fix this, its much eaiser (and less risky) to inline the enum variant fields fromCandidateRouteHopinto structs. This also lets us make some of the fields non-public, which seems better at least for the opaquehint_idxin the blinded paths.