upgrade libsql-js: 0.4.1 -> 0.4.4 #262
Merged
+100
−159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ add vector sync example
sivukhin
commented
Sep 13, 2024
| }, | ||
| "optionalDependencies": { | ||
| "@libsql/darwin-arm64": "0.4.1", |
There was a problem hiding this comment.
Hm....not sure why this huge diff is produced...
I just run npm install in the root of the project which automatically fix package-lock.json...
There was a problem hiding this comment.
I think this is due to the fix I made for having a cyclic dependency so this makes sense
sivukhin
requested review from
penberg and
LucioFranco
and removed request for
penberg
LucioFranco
approved these changes
Sep 13, 2024
| }, | ||
| "optionalDependencies": { | ||
| "@libsql/darwin-arm64": "0.4.1", |
There was a problem hiding this comment.
I think this is due to the fix I made for having a cyclic dependency so this makes sense
alcpereira
reviewed
Sep 13, 2024
| @@ -0,0 +1,51 @@ | |||
| import { createClient } from "@libsql/client"; | |||
| import reader from "readline-sync"; | |||
There was a problem hiding this comment.
This example suggests a deprecated lib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need latest version of
libsql-jsto have full vector support in embedded replicasThis PR also adds simple example with vector feature in embedded replica.