Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send user agent during auto tls #2932

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Feb 3, 2025

Sends a js-libp2p specific user agent to libp2p.direct while configuring the ACME DNS-01 response.

The user agent can be overridden but the default is something like:

js-libp2p/2.5.1 node/20.1.5

Refs: ipshipyard/p2p-forge#48

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Sorry, something went wrong.

Sends a js-libp2p specific user agent to libp2p.direct while
configuring the ACME DNS-01 response.
@achingbrain achingbrain force-pushed the fix/send-user-agent-during-autotls branch from f3ad3ae to c52c50a Compare February 3, 2025 16:16
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just left a comment

@achingbrain achingbrain merged commit 80ddad5 into main Feb 4, 2025
32 checks passed
@achingbrain achingbrain deleted the fix/send-user-agent-during-autotls branch February 4, 2025 06:45
@achingbrain achingbrain mentioned this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants