Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce dht logging and update metrics #2725

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

achingbrain
Copy link
Member

Make some more verbose logging trace logging and switch metrics to use separate operation/error metrics.

Refs: https://promlabs.com/blog/2023/09/19/errors-successes-totals-which-metrics-should-i-expose-to-prometheus/

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Sorry, something went wrong.

Make some more verbose logging trace logging and switch metrics to
use separate operation/error metrics.

Refs: https://promlabs.com/blog/2023/09/19/errors-successes-totals-which-metrics-should-i-expose-to-prometheus/
@achingbrain achingbrain requested a review from a team as a code owner September 25, 2024 11:48

Verified

This commit was signed with the committer’s verified signature. The key has expired.
danielleadams Danielle Adams
@achingbrain achingbrain merged commit 80fb47f into main Sep 25, 2024
21 checks passed
@achingbrain achingbrain deleted the fix/reduce-dht-logging-and-update-metrics branch September 25, 2024 13:06
@achingbrain achingbrain mentioned this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant