Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump aegir from 43.0.3 to 44.0.1 #2603

Merged
merged 5 commits into from
Jul 29, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 1, 2024

Bumps aegir from 43.0.3 to 44.0.1.

Release notes

Sourced from aegir's releases.

v44.0.1

44.0.1 (2024-07-01)

Documentation

v44.0.0

44.0.0 (2024-06-21)

⚠ BREAKING CHANGES

  • linting rules may have changed

Bug Fixes

Trivial Changes

Changelog

Sourced from aegir's changelog.

44.0.1 (2024-07-01)

Documentation

44.0.0 (2024-06-21)

⚠ BREAKING CHANGES

  • linting rules may have changed

Bug Fixes

Trivial Changes

43.0.2 (2024-06-21)

Bug Fixes

Trivial Changes

Dependencies

  • bump @​semantic-release/commit-analyzer from 12.0.0 to 13.0.0 (#1544) (ce5264c)
  • bump @​semantic-release/release-notes-generator (#1543) (14eaa50)
  • bump @​typescript-eslint/eslint-plugin from 5.62.0 to 7.13.1 (#1558) (22f4cf5)
  • bump c8 from 9.1.0 to 10.1.2 (#1555) (ce31644)

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner July 1, 2024 11:14
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jul 1, 2024
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/aegir-44.0.1 branch 3 times, most recently from f8d723e to 4fa2226 Compare July 3, 2024 13:39
Bumps [aegir](https://github.com/ipfs/aegir) from 43.0.3 to 44.0.1.
- [Release notes](https://github.com/ipfs/aegir/releases)
- [Changelog](https://github.com/ipfs/aegir/blob/master/CHANGELOG.md)
- [Commits](ipfs/aegir@v43.0.3...v44.0.1)

---
updated-dependencies:
- dependency-name: aegir
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/aegir-44.0.1 branch from 4fa2226 to e0212c5 Compare July 13, 2024 13:48

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@@ -6,7 +6,7 @@ export default {
get (win = globalThis) {
const nativeCrypto = win.crypto

if (nativeCrypto == null || nativeCrypto.subtle == null) {
if (nativeCrypto?.subtle == null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If crypto is not supported at all (which would be extremely rare in modern environments), win.crypto would be undefined so isn't if (nativeCrypto == null || nativeCrypto.subtle == null) safer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional chaining makes the additional null guard unnecessary:

const derp = null
// null

derp?.foo
// undefined

derp == null
// true

derp?.foo == null
// true

Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 29, 2024

A newer version of aegir exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@achingbrain achingbrain merged commit 944935f into main Jul 29, 2024
24 checks passed
@achingbrain achingbrain deleted the dependabot/npm_and_yarn/aegir-44.0.1 branch July 29, 2024 13:33
@achingbrain achingbrain mentioned this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants