deps: bump aegir from 43.0.3 to 44.0.1 #2603
Merged
+57
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/aegir-44.0.1
branch
3 times, most recently
from
f8d723e to
4fa2226
Compare
Bumps [aegir](https://github.com/ipfs/aegir) from 43.0.3 to 44.0.1. - [Release notes](https://github.com/ipfs/aegir/releases) - [Changelog](https://github.com/ipfs/aegir/blob/master/CHANGELOG.md) - [Commits](ipfs/aegir@v43.0.3...v44.0.1) --- updated-dependencies: - dependency-name: aegir dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/aegir-44.0.1
branch
from
4fa2226 to
e0212c5
Compare
maschad
reviewed
Jul 26, 2024
| @@ -6,7 +6,7 @@ export default { | |||
| get (win = globalThis) { | |||
| const nativeCrypto = win.crypto | |||
|
|
|||
| if (nativeCrypto == null || nativeCrypto.subtle == null) { | |||
| if (nativeCrypto?.subtle == null) { | |||
There was a problem hiding this comment.
If crypto is not supported at all (which would be extremely rare in modern environments), win.crypto would be undefined so isn't if (nativeCrypto == null || nativeCrypto.subtle == null) safer?
There was a problem hiding this comment.
Optional chaining makes the additional null guard unnecessary:
const derp = null
// null
derp?.foo
// undefined
derp == null
// true
derp?.foo == null
// true
|
A newer version of aegir exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps aegir from 43.0.3 to 44.0.1.
Release notes
Sourced from aegir's releases.
Changelog
Sourced from aegir's changelog.
... (truncated)
Commits
fe833e3chore(release): 44.0.1 [skip ci]559395fdocs: fix typo - it's -> its (#1566)62030b6chore(release): 44.0.0 [skip ci]ce225e0fix!: update linting related deps88c2e6043.0.3da4b8e2chore(release): 43.0.2 [skip ci]fea9decchore(release): 43.0.2 [skip ci]Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)