feat: add isDialable method to libp2p #2479
Merged
+125
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dialing peers is expensive, as are peer routing queries. Dials can be rejected due to configuration (no transport, connection gating, etc) - if a user is in the middle of a routing query they may wish to test dialability and continue the query instead of assuming they've found a dialable peer. Adds an `isDialable` method to libp2p that given a multiaddr, allows testing it to ensure libp2p won't reject the dial attempt due to how the node has been configured.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dialing peers is expensive, as are peer routing queries. Dials can be rejected due to configuration (no transport, connection gating, etc) - if a user is in the middle of a routing query they may wish to test dialability and continue the query instead of assuming they've found a dialable peer.
Adds an
isDialablemethod to libp2p that given one or more multiaddrs, allows testing them to ensure libp2p won't immediately reject the dial attempt due to how the node has been configured.Change checklist