Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to ConcurrentLinkedQueue to avoid expensive size calls #2602

Closed
okg-cxf opened this issue Jan 18, 2024 · 2 comments
Closed

Switch to ConcurrentLinkedQueue to avoid expensive size calls #2602

okg-cxf opened this issue Jan 18, 2024 · 2 comments
Labels
type: enhancement A general enhancement
Milestone
6.3.2.RELEASE

Comments

@okg-cxf
Copy link

okg-cxf commented Jan 18, 2024

Feature Request

ConcurrentLinkedDeque has unnecessary overhead because it needs to maintain an extra volatile prev pointer.

Is your feature request related to a problem? Please describe

No

Describe the solution you'd like

Replace with ConcurrentLinkedQueue instead

Describe alternatives you've considered

No

Teachability, Documentation, Adoption, Migration Strategy

N.A.
@okg-cxf
Copy link
Author

okg-cxf commented Jan 18, 2024

see #2601

@okg-cxf okg-cxf mentioned this issue Jan 18, 2024
Closed
@mp911de
Copy link
Collaborator

mp911de commented Jan 18, 2024

Thanks a lot for reaching out. Do you have any metrics (or pointer) that underline the change?

@mp911de mp911de changed the title why not use ConcurrentLinkedQueue? Switch to ConcurrentLinkedQueue to avoid expensive size calls Feb 26, 2024
@mp911de mp911de added this to the 6.3.2.RELEASE milestone Feb 26, 2024
@mp911de mp911de added the type: enhancement A general enhancement label Feb 26, 2024
mp911de added a commit that referenced this issue Feb 26, 2024
@mp911de
Switch to ConcurrentLinkedQueue to avoid expensive size calls #2602
faffc7e 
See also #2601
mp911de added a commit that referenced this issue Feb 26, 2024
@mp911de
Switch to ConcurrentLinkedQueue to avoid expensive size calls #2602
18750c1 
See also #2601
@mp911de mp911de linked a pull request Feb 26, 2024 that will close this issue
Eliminate unnecessary expensive size() calls, use ConcurrentLinkedQueue instead of ConcurrentLinkedDeque #2601
Closed
@mp911de mp911de closed this as completed Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
6.3.2.RELEASE
2 participants
@mp911de @okg-cxf