Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling kid check with jws.Verify on a JWKSet #1089

Closed
lestrrat opened this issue Mar 7, 2024 Discussed in #1083 · 2 comments
Closed

Disabling kid check with jws.Verify on a JWKSet #1089

lestrrat opened this issue Mar 7, 2024 Discussed in #1083 · 2 comments
Assignees
@lestrrat

Comments

@lestrrat
Copy link
Collaborator

lestrrat commented Mar 7, 2024

Discussed in #1083

Originally posted by rishid March 1, 2024
I am trying to use jws.verify with a KeySet and want to set the kid required to false. The comment mentions adding this jws.WithKeySetSuboption(jws.WithKeySetRequireKid(false)) as an option but this does not work and it seems like the code doesn't exist.

Referenced line:

jwx/jws/options.go

Line 139 in ace7a77

// the suboption `WithKeySetRequired` via `jws.WithKeySetSuboption(jws.WithKeySetRequireKid(false))`.

@lestrrat
Copy link
Collaborator Author

lestrrat commented Mar 7, 2024

The documentation is misleading

@lestrrat
Copy link
Collaborator Author

lestrrat commented Mar 7, 2024

This was done in #1090

@lestrrat lestrrat closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lestrrat lestrrat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lestrrat